Apache Commons logo Commons FileUpload

PMD Results

The following document contains the results of PMD 6.52.0.

Violations By Priority

Priority 1

org/apache/commons/fileupload/FileUploadBase.java

Rule Violation Line
ReturnEmptyCollectionRatherThanNull Return an empty collection rather than null. 456

Priority 3

org/apache/commons/fileupload/FileUploadBase.java

Rule Violation Line
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 693
CloseResource Ensure that resources like this ItemInputStream object are closed after use 811
CloseResource Ensure that resources like this ItemInputStream object are closed after use 812
CloseResource Ensure that resources like this InputStream object are closed after use 1001
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 1062
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 1079

org/apache/commons/fileupload/MultipartStream.java

Rule Violation Line
AssignmentInOperand Avoid assignments in operands 572

org/apache/commons/fileupload/ParameterParser.java

Rule Violation Line
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 311

org/apache/commons/fileupload/disk/DiskFileItem.java

Rule Violation Line
AvoidFieldNameMatchingMethodName Field isFormField has the same name as a method 111
CloseResource Ensure that resources like this InputStream object are closed after use 309
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 315
CloseResource Ensure that resources like this FileOutputStream object are closed after use 387
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 429
FinalizeDoesNotCallSuperFinalize Last statement in finalize method should be a call to super.finalize() 549551

org/apache/commons/fileupload/util/Streams.java

Rule Violation Line
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 115
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 118

org/apache/commons/fileupload/util/mime/QuotedPrintableDecoder.java

Rule Violation Line
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 59
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 61
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 72
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 73

Files

org/apache/commons/fileupload/FileUploadBase.java

Rule Violation Priority Line
ReturnEmptyCollectionRatherThanNull Return an empty collection rather than null. 1 456
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 693
CloseResource Ensure that resources like this ItemInputStream object are closed after use 3 811
CloseResource Ensure that resources like this ItemInputStream object are closed after use 3 812
CloseResource Ensure that resources like this InputStream object are closed after use 3 1001
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 1062
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 1079

org/apache/commons/fileupload/MultipartStream.java

Rule Violation Priority Line
AssignmentInOperand Avoid assignments in operands 3 572

org/apache/commons/fileupload/ParameterParser.java

Rule Violation Priority Line
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 311

org/apache/commons/fileupload/disk/DiskFileItem.java

Rule Violation Priority Line
AvoidFieldNameMatchingMethodName Field isFormField has the same name as a method 3 111
CloseResource Ensure that resources like this InputStream object are closed after use 3 309
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 315
CloseResource Ensure that resources like this FileOutputStream object are closed after use 3 387
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 429
FinalizeDoesNotCallSuperFinalize Last statement in finalize method should be a call to super.finalize() 3 549551

org/apache/commons/fileupload/util/Streams.java

Rule Violation Priority Line
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 115
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 118

org/apache/commons/fileupload/util/mime/QuotedPrintableDecoder.java

Rule Violation Priority Line
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 59
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 61
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 72
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 3 73